refactor: remove gRPC reflection v1-alpha support#1795
Merged
Mirko-von-Leipzig merged 6 commits into0xMiden:nextfrom Mar 16, 2026
Merged
refactor: remove gRPC reflection v1-alpha support#1795Mirko-von-Leipzig merged 6 commits into0xMiden:nextfrom
Mirko-von-Leipzig merged 6 commits into0xMiden:nextfrom
Conversation
bobbinth
approved these changes
Mar 14, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you!
We should probably add a changelog entry here since this is a change in user-facing functionality.
Mirko-von-Leipzig
approved these changes
Mar 15, 2026
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Thank you! If you could add a changelog entry as @bobbinth suggested, we're good to go.
Contributor
Author
|
@bobbinth @Mirko-von-Leipzig Added changelog, sorru for the delay with issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the gRPC server reflection v1-alpha service from all server components (rpc, store, validator, block-producer). Postman now supports gRPC reflection v1, so the v1-alpha workaround added in #1036 is no longer needed.
Closes #1717